Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining block contents with newline #152

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Joining block contents with newline #152

merged 3 commits into from
Jan 10, 2019

Conversation

EriksRemess
Copy link
Contributor

Current version joins block contents with a comma, should be with a newline.

Current version joins block contents with a comma, should be with a newline.
Copy link
Collaborator

@jtwebman jtwebman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@jtwebman jtwebman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this?

@jtwebman jtwebman added the need-tests PR needs some tests to show it fixing the issue or exercising the feature label Jan 10, 2019
@EriksRemess
Copy link
Contributor Author

test added

@jtwebman jtwebman removed the need-tests PR needs some tests to show it fixing the issue or exercising the feature label Jan 10, 2019
@jtwebman jtwebman merged commit 9aa1275 into TryGhost:master Jan 10, 2019
@jtwebman
Copy link
Collaborator

jtwebman commented Jan 10, 2019

Thank you @EriksRemess for this PR! I did a release 2.0.1 with this fix in it.

@EriksRemess EriksRemess deleted the patch-1 branch January 11, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants