Add support for dynamic template options v1x #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because we should not be modifing objects that do not belong to us. The locals object belongs to the express application, outside of express-hbs.
Used the word update here rather than set to match the global template options method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #154 - but for the v1.x branch
This also installs
lodash, so that we have access to the_.mergefunction used to join the local template options with the global ones.Currently template options are global for a single ExpressHbs instance. They are set through the updateTemplateOptions method.
This PR adds support for "local" template options so that they can be configured on a request by request basis.
The renderTemplate function now reads the _templateOptions property from res.locals and merges those with the global template options before passing them to the template to be rendered.
There are 2 new methods on ExpressHbs to abstract over getting and setting the _templateOptions property on a locals object - so it can be changed in the future.