💡 Changed the lock_key column constraint to primary key #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpatel
force-pushed
the
master
branch
2 times, most recently
from
ad8bb71
to
fdd58cb
Compare
naz
reviewed
Feb 23, 2021
issue https://github.com/TryGhost/Team/issues/267 Tables without primary keys cause issues with MySQL replication & clustering.
tpatel
force-pushed
the
change-lock-key-constraint-to-pk
branch
2 times, most recently
from
5e7cc7d
to
b5b7583
Compare
daniellockyer
approved these changes
Feb 24, 2021
issue TryGhost/Team#267 - Tables without primary keys cause issues with MySQL replication & clustering.
tpatel
force-pushed
the
change-lock-key-constraint-to-pk
branch
from
b5b7583
to
169ebf6
Compare
daniellockyer
approved these changes
Feb 24, 2021
naz
reviewed
Feb 24, 2021
| @@ -798,5 +798,23 @@ _.each(['default', 'migrateInit'], function (initMethod) { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it('change current version', function () { | |||
|
@tpatel our of curiosity, was there a particular reason why we didn't go with async/await syntax here? The change is good otherwise 🚀 |
|
Also, approving this with knowledge in mind that the primary key migrations were copied from Ghost and will be extracted into utilities package when there's time. For now it's a "good enough" approach 👍 |
The reason is that the linter was screaming at me for using async/await for some reason, and I didn't want to go down a rabbit hole changing it so I followed its directions 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue https://github.com/TryGhost/Team/issues/267
Tables without primary keys cause issues with MySQL replication & clustering.