Skip to content

Commit

Permalink
Reworked CI versions
Browse files Browse the repository at this point in the history
- bumped building on Node 16 to Node 18
- removed all matrix executions apart from Node 18
  • Loading branch information
daniellockyer committed Dec 24, 2023
1 parent cff38a3 commit 9e8b2ee
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 17 deletions.
24 changes: 8 additions & 16 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,14 @@ jobs:
target:
- x64
node:
- 10
- 11
- 12
- 13
- 14
- 15
- 16
- 17
- 18
include:
- os: windows-latest
node: 16
node: 18
host: x86
target: x86
- os: macos-m1
node: 16
node: 18
host: arm64
target: arm64
name: ${{ matrix.os }} (node=${{ matrix.node }}, host=${{ matrix.host }}, target=${{ matrix.target }})
Expand Down Expand Up @@ -113,15 +105,15 @@ jobs:

- name: Upload binaries to commit artifacts
uses: actions/upload-artifact@v3
if: matrix.node == 16
if: matrix.node == 18
with:
name: prebuilt-binaries
path: build/stage/*/*
retention-days: 7

- name: Upload binaries to GitHub Release
run: yarn node-pre-gyp-github publish
if: matrix.node == 16 && startsWith(github.ref, 'refs/tags/')
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
env:
NODE_PRE_GYP_GITHUB_TOKEN: ${{ github.token }}
build-qemu:
Expand All @@ -131,7 +123,7 @@ jobs:
fail-fast: false
matrix:
node:
- 16
- 18
target:
- linux/arm64
variant:
Expand All @@ -141,7 +133,7 @@ jobs:
# musl x64 builds
- target: linux/amd64
variant: alpine3.15
node: 16
node: 18
name: ${{ matrix.variant }} (node=${{ matrix.node }}, target=${{ matrix.target }})
steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
Expand All @@ -168,14 +160,14 @@ jobs:
- name: Upload binaries to commit artifacts
uses: actions/upload-artifact@v3
if: matrix.node == 16
if: matrix.node == 18
with:
name: prebuilt-binaries
path: build/stage/*/*
retention-days: 7

- name: Upload binaries to GitHub Release
run: yarn install --ignore-scripts && yarn node-pre-gyp-github publish
if: matrix.node == 16 && startsWith(github.ref, 'refs/tags/')
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
env:
NODE_PRE_GYP_GITHUB_TOKEN: ${{ github.token }}
2 changes: 1 addition & 1 deletion tools/BinaryBuilder.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG NODE_VERSION=16
ARG NODE_VERSION=18
ARG VARIANT=bullseye

FROM node:$NODE_VERSION-$VARIANT
Expand Down

0 comments on commit 9e8b2ee

Please sign in to comment.