Improve connection speed/reliability and add more logging around connections #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using backend data directories like `Quietdev`, `Quietdev1`, `Quietdev2', restarting the process using `Quietdev` can result in that process killing the other backend processes due to the grep command used for finding hanging processes. Example: ``` user (Quietdev1): desktop:main:main Forked backend, PID: 214543 owner (Quietdev): Found 1 hanging backend process(es) with pid(s) 214543. Killing... ```
iOS appears to not be syncing correctly after resuming from suspend. It looks like this is due to the libp2p auto-dialler getting stuck connecting to the Tor HTTP tunnel port which is replaced after suspend/resume. This commit enables the WebsocketOverTor transport to use the `dialTimeout` correctly. But still this means the current dialer waits for `dialTimeout` to try another peer, and we currently have `dialTimeout` set to 2 minutes. Ideally, we can find a better approach for closing any sockets when suspending the app or detecting when we are trying to connect to a port that nothing is listening on, if that's possible.
* Better peer sorting and updated initial diallng * Update tests
* Fix issue of duplicate CRSs being generated * Install LFS with checkout to avoid random errors
Fixes for the following issues: - Peers can be deleted if CSRs don't sync - Backend starting before the frontend is ready, resulting in missed events - Adding duplicate CSRs
* fix: start websocket connection on react init * chore: restore self hosted ios e2e tests * fix: prevent stripping hermes framework * Revert "fix: prevent stripping hermes framework" This reverts commit 65dfec8. * chore: skip self-hosted ios e2e tests
* Fix issue with connecting on resume on ios * Update changelogs
* chore: start own metro * chore: comment out restore connection saga usage * chore: repeat websocket connection tries on android * chore: update pods * chore: increase action timeout * fix: always stop metro * chore: limit intervals * chore: enlarge intervals * fix: use callback on react app init * chore: remove redundand sagas * fix: move app_ready event * test: mock native modules
* Extra logging, blocking actions and random UX error fix * Some more changes * Add more logs * Connect to tor when we should and update peers on connect * Redial when tor is fully ready * More logs, spawn hidden services early again, better hang up and mild refactor of tor * PR fixes * More fixes * Small fix * Fix tests * Fix setup environment on mac in ci * Fix mac e2e filename * Update e2e-mac.yml * Update e2e-mac.yml * Comment fix and better redial on resume * Add back fix I accidentally removed * Don't redial on tor initialization * Update .detoxrc.js * Revert "Update .detoxrc.js" This reverts commit 9290f25.
…vant changes found (#2488)
This reverts commit 6225d97.
* macos-latest -> macos-12 (#2482) * fix: use explicit macos-12 image instead of macos-latest ('-latest' image was updated to macos-14) * Update e2e-mac.yml * Run e2e on e2e changes --------- Co-authored-by: breadhunter <6099829+EmiM@users.noreply.github.com>
…times and close backend server properly (#2499)
* Process queue fixes and updates * Remove unnecessary log * Log when we push to queue
…te queue, don't dial if the peer is in the peerstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make connecting to new peers, especially when opening the app or resuming the app (iOS), noticeably faster with fewer errors when connecting to peers that are online.
doPXon libp2p connection manager (PX allows peers to share peer information with each other)Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: