Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(2672): Show breaking changes modals on desktop and mobile #2705

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

islathehut
Copy link
Collaborator

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@islathehut
Copy link
Collaborator Author

#2672

@islathehut islathehut marked this pull request as ready for review January 20, 2025 19:21
* https://github.com/TryQuiet/quiet/issues/2672
*/
useEffect(() => {
dispatch(navigationActions.navigation({ screen: ScreenNames.NotifierScreen }))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a bit of process redundancy, we could put in a check on current version of the app which only dispatches this if version is 2.x just in case this logic sneaks into 3.0 or further on

@islathehut islathehut changed the base branch from develop to 2.4.0 January 21, 2025 14:31
@islathehut islathehut merged commit b58ed1e into 2.4.0 Jan 21, 2025
26 of 31 checks passed
@islathehut islathehut deleted the chore/pre-3.0-changes branch January 21, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants