Skip to content

Commit

Permalink
delete unneeded test
Browse files Browse the repository at this point in the history
  • Loading branch information
reuvenharrison committed Feb 3, 2025
1 parent e035db0 commit 9d08a81
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
22 changes: 0 additions & 22 deletions checker/check_request_parameter_deprecation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,25 +187,3 @@ func TestParameterDeprecated_DetectsReactivated(t *testing.T) {
require.Equal(t, "/api/test", e0.Path)
require.Equal(t, "'query' request parameter 'id' was reactivated", e0.GetUncolorizedText(checker.NewDefaultLocalizer()))
}

// func TestBreaking_InvaidStability(t *testing.T) {

// s1, err := open(getParameterDeprecationFile("invalid-stability.yaml"))
// require.NoError(t, err)

// s2, err := open(getParameterDeprecationFile("base-alpha-stability.yaml"))
// require.NoError(t, err)

// d, osm, err := diff.GetWithOperationsSourcesMap(diff.NewConfig(), s1, s2)
// require.NoError(t, err)
// errs := checker.CheckBackwardCompatibility(singleCheckConfig(checker.ParameterDeprecationCheck), d, osm)
// require.Len(t, errs, 1)

// require.IsType(t, checker.ApiChange{}, errs[0])
// e0 := errs[0].(checker.ApiChange)
// require.Equal(t, checker.APIInvalidStabilityLevelId, e0.Id)
// require.Equal(t, "GET", e0.Operation)
// require.Equal(t, "/api/test", e0.Path)
// require.Equal(t, "failed to parse stability level: 'value is not one of draft, alpha, beta or stable: \"ga\"'", e0.GetUncolorizedText(checker.NewDefaultLocalizer()))
// require.Equal(t, "../data/deprecation/invalid-stability.yaml", errs[0].GetSource())
// }
22 changes: 22 additions & 0 deletions data/param-deprecation/base-invalid-stability.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
info:
title: Tufin
version: 1.0.0
openapi: 3.0.3
paths:
/api/test:
get:
x-stability-level: invalid
parameters:
- $ref: '#/components/parameters/id'
responses:
200:
description: OK
components:
parameters:
id:
name: id
in: query
required: true
schema:
type: string
description: 'The ID'

0 comments on commit 9d08a81

Please sign in to comment.