Skip to content

Commit

Permalink
Make zdb results for checkpoint tests consistent
Browse files Browse the repository at this point in the history
This patch exports and re-imports the pool when these tests are
analyzed with zdb to get consistent results.

Reviewed by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Closes openzfs#8292
  • Loading branch information
sdimitro authored and behlendorf committed Jan 16, 2019
1 parent 6e91a72 commit db58794
Showing 1 changed file with 13 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,19 @@ function fragment_after_checkpoint_and_verify
#
log_must zpool list -v

log_must zdb $NESTEDPOOL
log_must zdb -kc $NESTEDPOOL
#
# Typically we would just run zdb at this point and things
# would be fine. Unfortunately, if there is still any
# background I/O in the pool the zdb command can fail with
# checksum errors temporarily.
#
# Export the pool when running zdb so the pool is idle and
# the verification results are consistent.
#
log_must zpool export $NESTEDPOOL
log_must zdb -e -p $FILEDISKDIR $NESTEDPOOL
log_must zdb -e -p $FILEDISKDIR -kc $NESTEDPOOL
log_must zpool import -d $FILEDISKDIR $NESTEDPOOL
}

function wait_discard_finish
Expand Down

0 comments on commit db58794

Please sign in to comment.