js/jquery: Allow non-tab links in the sidebar

Turbo87 · Nov 1, 2016 · 3905461 · 3905461
1 parent 7956c0a
commit 3905461
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 2 deletions.
diff --git a/examples/gmaps.html b/examples/gmaps.html
@@ -34,6 +34,7 @@
                 <li><a href="#home" role="tab"><i class="fa fa-bars"></i></a></li>
                 <li><a href="#profile" role="tab"><i class="fa fa-user"></i></a></li>
                 <li class="disabled"><a href="#messages" role="tab"><i class="fa fa-envelope"></i></a></li>
+                <li><a href="https://github.com/Turbo87/sidebar-v2" role="tab" target="_blank"><i class="fa fa-github"></i></a></li>
             </ul>
 
             <ul role="tablist">

diff --git a/examples/index.html b/examples/index.html
@@ -36,6 +36,7 @@
                 <li><a href="#home" role="tab"><i class="fa fa-bars"></i></a></li>
                 <li><a href="#profile" role="tab"><i class="fa fa-user"></i></a></li>
                 <li class="disabled"><a href="#messages" role="tab"><i class="fa fa-envelope"></i></a></li>
+                <li><a href="https://github.com/Turbo87/sidebar-v2" role="tab" target="_blank"><i class="fa fa-github"></i></a></li>
             </ul>
 
             <ul role="tablist">

diff --git a/examples/ol2.html b/examples/ol2.html
@@ -35,6 +35,7 @@
                 <li><a href="#home" role="tab"><i class="fa fa-bars"></i></a></li>
                 <li><a href="#profile" role="tab"><i class="fa fa-user"></i></a></li>
                 <li class="disabled"><a href="#messages" role="tab"><i class="fa fa-envelope"></i></a></li>
+                <li><a href="https://github.com/Turbo87/sidebar-v2" role="tab" target="_blank"><i class="fa fa-github"></i></a></li>
             </ul>
 
             <ul role="tablist">

diff --git a/examples/ol3-no-jquery.html b/examples/ol3-no-jquery.html
@@ -36,6 +36,7 @@
                 <li><a href="#home" role="tab"><i class="fa fa-bars"></i></a></li>
                 <li><a href="#profile" role="tab"><i class="fa fa-user"></i></a></li>
                 <li class="disabled"><a href="#messages" role="tab"><i class="fa fa-envelope"></i></a></li>
+                <li><a href="https://github.com/Turbo87/sidebar-v2" role="tab" target="_blank"><i class="fa fa-github"></i></a></li>
             </ul>
 
             <ul role="tablist">

diff --git a/examples/ol3.html b/examples/ol3.html
@@ -36,6 +36,7 @@
                 <li><a href="#home" role="tab"><i class="fa fa-bars"></i></a></li>
                 <li><a href="#profile" role="tab"><i class="fa fa-user"></i></a></li>
                 <li class="disabled"><a href="#messages" role="tab"><i class="fa fa-envelope"></i></a></li>
+                <li><a href="https://github.com/Turbo87/sidebar-v2" role="tab" target="_blank"><i class="fa fa-github"></i></a></li>
             </ul>
 
             <ul role="tablist">

diff --git a/examples/position-right.html b/examples/position-right.html
@@ -36,6 +36,7 @@
                 <li><a href="#home" role="tab"><i class="fa fa-bars"></i></a></li>
                 <li><a href="#profile" role="tab"><i class="fa fa-user"></i></a></li>
                 <li class="disabled"><a href="#messages" role="tab"><i class="fa fa-envelope"></i></a></li>
+                <li><a href="https://github.com/Turbo87/sidebar-v2" role="tab" target="_blank"><i class="fa fa-github"></i></a></li>
             </ul>
 
             <ul role="tablist">

diff --git a/js/jquery-sidebar.js b/js/jquery-sidebar.js
@@ -19,7 +19,7 @@ $.fn.sidebar = function(options) {
 
     $sidebar.addClass('sidebar-' + options.position);
 
-    $tabs.children('li').children('a').on('click', function(e) {
+    $tabs.children('li').children('a[href^="#"]').on('click', function(e) {
         e.preventDefault();
         var $tab = $(this).closest('li');
 

diff --git a/js/jquery-sidebar.min.js b/js/jquery-sidebar.min.js