Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for OpenLayers 6 was failing due to
ol.inherits
removal in OpenLayers 6 (release notes reference). I've made correction with a "if else" to manage code for both OpenLayers 5 and 6. My choice has been to not create a function as there was only one call toinherits
in theol3-sidebar.js
base code. I've borrowed the logic from https://gis.stackexchange.com/a/324607 without using a function.Need a review.
A suggestion after this commit would be to remove reference to
ol3-sidebar.js
and rename it tool-sidebar.js
, do the same forol3-sidebar.css
(would beol-sidebar.css
) and change the doc to mention OpenLayers 3+ (version is now 6.1.1)