Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming removeFrom to remove #73

Merged
merged 3 commits into from
Aug 1, 2016
Merged

renaming removeFrom to remove #73

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71ca76d
renaming removeFrom to remove
MuellerMatthew May 19, 2016
d6645e9
adding depreciated warning to removeFrom()
MuellerMatthew May 26, 2016
1a9234a
Update leaflet-sidebar.js
MuellerMatthew May 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion js/leaflet-sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,25 @@ L.Control.Sidebar = L.Control.extend(/** @lends L.Control.Sidebar.prototype */ {

return this;
},

/**
* @deprecated - Please use remove() instead of removeFrom(), as of Leaflet 0.8-dev, the removeFrom() has been replaced with remove()
* Removes this sidebar from the map.
* @param {L.Map} map
* @returns {Sidebar}
*/
removeFrom: function(map) {
console.log('removeFrom() has been deprecated, please use remove() instead as support for this function will be ending soon.');
this.remove(map);
},

/**
* Remove this sidebar from the map.
*
* @param {L.Map} map
* @returns {Sidebar}
*/
removeFrom: function (map) {
remove: function (map) {
var i, child;

this._map = null;
Expand Down