Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle percentage format for font size, table height, width and margin #10

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Handle percentage format for font size, table height, width and margin #10

merged 5 commits into from
Apr 4, 2024

Conversation

K-Kumar-01
Copy link
Collaborator

  • Handle percentage format for fontsize, table height and width.
  • Temporarily handle percentage formats for margins.

@K-Kumar-01
feat: handle percentage for fontsize
ae7a0b8 
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
@K-Kumar-01
feat: handle percentage for table height
1dcd82d 
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
@K-Kumar-01
feat: handle percentage for table width
4668385 
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
@K-Kumar-01
fix: temporary handle percentage format for margins
dbe01d3 
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
nicolasiscoding
nicolasiscoding requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@nicolasiscoding nicolasiscoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add and call out test cases related to this PR

@K-Kumar-01
Copy link
Collaborator Author

K-Kumar-01 commented Apr 4, 2024 •
edited
Loading

There are no such test cases as we simply pass the height and width in percentage format.
Updated samples with a testcase.

Let me know if any changes are needed

@K-Kumar-01
docs: add percentage height and px height examples
c92c03c 
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
@nicolasiscoding
Copy link
Member

This will require a further ticket for refinement, but at least we don't get blank tables. Thank you for this! @K-Kumar-01

@nicolasiscoding nicolasiscoding merged commit 9a1ba88 into develop Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasiscoding nicolasiscoding nicolasiscoding requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K-Kumar-01 @nicolasiscoding