Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin: Check Zero or Truth Values for Margin #29

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

K-Kumar-01
Copy link
Collaborator

No description provided.

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Copy link
Member

@nicolasiscoding nicolasiscoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, testing locallt

@nicolasiscoding nicolasiscoding added the bug Something isn't working label Jun 7, 2024
@nicolasiscoding nicolasiscoding merged commit 7c133d8 into develop Jun 7, 2024
nicolasiscoding pushed a commit that referenced this pull request Jun 25, 2024
* refactor: remove unused import

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* feat: add util to check zero or truthy value

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* fix: margin attributes building

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* docs: update example for lists

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

---------

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
nicolasiscoding added a commit that referenced this pull request Jun 26, 2024
* Create FUNDING.yml

* Feature/contributors update (#26)

* feat: add contributors

* fix: cleanup readme

* feat: add banner and updated package.json

* chore: fixes and update .gitignore

* chore: readme styling

* chore: readme refactor styling

* Create npm-publish.yml (#27)

* feat: cicd test

* chore: update package-lock.json

* feat: add build command to CI

* fix: bump version for NPM release

* Margin: Check Zero or Truth Values for Margin (#29)

* refactor: remove unused import

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* feat: add util to check zero or truthy value

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* fix: margin attributes building

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* docs: update example for lists

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

---------

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* chore: bump version with new fixes

* fix: move from console.warning to console.warn

---------

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Co-authored-by: Kushal Kumar <59891164+K-Kumar-01@users.noreply.github.com>
AmitSharma512 pushed a commit that referenced this pull request Jun 26, 2024
* refactor: remove unused import

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* feat: add util to check zero or truthy value

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* fix: margin attributes building

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

* docs: update example for lists

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>

---------

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants