-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Margin: Check Zero or Truth Values for Margin #29
Merged
nicolasiscoding
merged 4 commits into
develop
from
k-kumar-01/margin-zero-or-truthy-check
Jun 7, 2024
Merged
Margin: Check Zero or Truth Values for Margin #29
nicolasiscoding
merged 4 commits into
develop
from
k-kumar-01/margin-zero-or-truthy-check
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, testing locallt
nicolasiscoding
pushed a commit
that referenced
this pull request
Jun 25, 2024
* refactor: remove unused import Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * feat: add util to check zero or truthy value Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * fix: margin attributes building Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * docs: update example for lists Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> --------- Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
nicolasiscoding
added a commit
that referenced
this pull request
Jun 26, 2024
* Create FUNDING.yml * Feature/contributors update (#26) * feat: add contributors * fix: cleanup readme * feat: add banner and updated package.json * chore: fixes and update .gitignore * chore: readme styling * chore: readme refactor styling * Create npm-publish.yml (#27) * feat: cicd test * chore: update package-lock.json * feat: add build command to CI * fix: bump version for NPM release * Margin: Check Zero or Truth Values for Margin (#29) * refactor: remove unused import Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * feat: add util to check zero or truthy value Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * fix: margin attributes building Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * docs: update example for lists Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> --------- Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * chore: bump version with new fixes * fix: move from console.warning to console.warn --------- Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> Co-authored-by: Kushal Kumar <59891164+K-Kumar-01@users.noreply.github.com>
AmitSharma512
pushed a commit
that referenced
this pull request
Jun 26, 2024
* refactor: remove unused import Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * feat: add util to check zero or truthy value Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * fix: margin attributes building Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> * docs: update example for lists Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com> --------- Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.