Removal of redundant backwards compat to_namedtuple_expr
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryTimed out. |
|
It's surprising that integration tests take more than 6h now: Related TuringLang/Turing.jl#1660 |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
yebai
approved these changes
Jul 17, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2021
Looking at `to_namedtuple_expr` it seems like it's leftover code to be compatible with Julia 1.2. Given that DPPL only supports Julia 1.3 or higher I've simplified the implementation, doing away with the `namedtuple` method. EDIT: This also fixed a bug I ran into when using Zygote + `@submodel` in #267 . Struggling to come up with a MWE of the bug, but just adding merging this fixed it. This was also my original motivation for making this change, as Zygote was complaining about the `namedtuple` for some reason (something about "non-differentiable getfield"). Co-authored-by: Hong Ge <hg344@cam.ac.uk>
|
Timed out. |
|
Yup, it seems like what I mentioned in the other PR is the case: need to also upper-bound Distributions.jl in these tests too. |
|
I merged this PR since all CI tests appear to be passing. Not sure why |
As I said above, they're timing out because Distributions@0.12.11 is being used. Fixed in #282 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at
to_namedtuple_exprit seems like it's leftover code to be compatible with Julia 1.2. Given that DPPL only supports Julia 1.3 or higher I've simplified the implementation, doing away with thenamedtuplemethod.EDIT: This also fixed a bug I ran into when using Zygote +
@submodelin #267 . Struggling to come up with a MWE of the bug, but just adding merging this fixed it. This was also my original motivation for making this change, as Zygote was complaining about thenamedtuplefor some reason (something about "non-differentiable getfield").