CompatHelper: bump compat for AbstractPPL to 0.6, (keep existing compat) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
devmotion
force-pushed
the
compathelper/new_version/2022-12-10-00-09-02-297-02894846605
branch
from
fee92f0
to
f325073
Compare
yebai
approved these changes
Dec 19, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 19, 2022
…at) (#440) This pull request changes the compat entry for the `AbstractPPL` package from `0.5.1` to `0.5.1, 0.6`. This keeps the compat entries for earlier versions. Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.
|
Build failed: |
|
Could we please try to get this merged? This is currently causing a hard conflict for my package because of the Setfield compat requirements of |
…02-297-02894846605
|
bors try |
tryBuild failed: |
|
It's failing because after APPL@0.6 (more specifically, after TuringLang/AbstractPPL.jl#43) it seems we need to explicitly require concretization when calling |
|
It seems to me that we should just make |
bors bot
pushed a commit
to TuringLang/AbstractPPL.jl
that referenced
this pull request
Dec 29, 2022
Use `Setfield.need_dynamic_lens` as the default value for `concretize` in `varname`. This way we preserve pre-0.6 behavior, thus not make the 0.6-release "less" breaking. Ref: TuringLang/DynamicPPL.jl#440 Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
|
bors try |
tryBuild failed: |
…02-297-02894846605
…eep existing compat) (#469) * Fixed a typo in tutorial (#451) * CompatHelper: bump compat for Turing to 0.24 for package turing, (keep existing compat) (#450) This pull request changes the compat entry for the `Turing` package from `0.21` to `0.21, 0.24` for package turing. This keeps the compat entries for earlier versions. Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request. Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> * Some minor utility improvements (#452) This PR does the following: - Moves the `varname_leaves` from `TestUtils` to main module. - It can be very useful in Turing.jl for constructing `Chains` and the like, so I think it's a good idea to make it part of the main module rather than keeping it "hidden" there. - Makes the default `varinfo` in the constructor of `LogDensityFunction` be `model.context` rather than a new `DynamicPPL.DefaultContext`. - The `context` pass to `evaluate!!` will override the leaf-context in `model.context`, and so the current default constructor always uses `DefaultContext` as the leaf-context, even if the `Model` has been `contextualize`d with some other leaf-context, e.g. `PriorContext`. This PR fixes this issue. * Always run CI (#453) I find the current `bors` workflow a bit tedious. Most of the time, I summon `bors` to see the CI results (see e.g. #438). Given that most `CI` tests are quick (< 10mins), we can always run them by default. The most time-consuming `IntegrationTests` is still run by `bors` to avoid excessive CI runs. * Compat with new Bijectors.jl (#454) This PR makes DPPL compatible with the changes to come in TuringLang/Bijectors.jl#214. Tests are passing locally. Closes #455 Closes #456 * Another Bijectors.jl compat bound bump (#457) * CompatHelper: bump compat for MCMCChains to 6 for package test, (keep existing compat) (#467) This pull request changes the compat entry for the `MCMCChains` package from `4.0.4, 5` to `4.0.4, 5, 6` for package test. This keeps the compat entries for earlier versions. Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request. Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> * CompatHelper: bump compat for AbstractPPL to 0.6 for package test, (keep existing compat) --------- Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> Co-authored-by: github-actions[bot] <compathelper_noreply@julialang.org> Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
…02-297-02894846605
|
bors try |
tryConfiguration problem: |
…02-297-02894846605
|
Bors isn't used any more @sunxd3 We use merge queues, which effectively means that once the tests pass it can be put into the queue. Testst aren't passing here though, so can't do that yet. |
|
I realized that, so I trigger the CI to run again. Let me see what the test error says |
yebai
deleted the
compathelper/new_version/2022-12-10-00-09-02-297-02894846605
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
AbstractPPLpackage from0.5.1to0.5.1, 0.6.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.