-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithinGibbs
sampler implementations
#131
Conversation
Pull Request Test Coverage Report for Build 6841824404Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 75.75% 77.21% +1.46%
==========================================
Files 20 21 +1
Lines 1757 1826 +69
==========================================
+ Hits 1331 1410 +79
+ Misses 426 416 -10 ☔ View full report in Codecov by Sentry. |
MarkovBlanketBUGSModel constructor
@yebai I think this is finally ready. Some tests may fail, but they should be okay, just artifacts from The I removed |
The numbers here seem quite off from the ground truth -- maybe double-check the implementation? |
@yebai I have never seen this happens before, and it's produced by running HMC in a Gibbs fashion. Is it possible that this is just one bad chain? |
@yebai some tests are passing so I think the implementation is correct. For that I think this PR can be merged. The issue is that Gibbs runs slowly for many reasons include type unsuitability and unnecessary deepcopies, so I can't make it work and test on slightly larger models. I'll do a refactor and an efficiency update to make it runs better, but that belongs to another PR. |
This PR:
condition
anddecondition
interface similar to those ofDynamicPPL
, addressing Supportcondition
/decondition
syntax similiar toDynamicPPL
. #132JuliaBUGS.MHFromPrior