Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename analysis functions #141

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Rename analysis functions #141

merged 5 commits into from
Feb 26, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Feb 26, 2024

The original names program!, for_loops!, and assignment! are confusing, so renamed them for better clarity.
Also some docstrings are removed: the code should be clear enough.
No actual changes.

src/compiler_pass.jl Outdated Show resolved Hide resolved
src/compiler_pass.jl Outdated Show resolved Hide resolved
src/compiler_pass.jl Outdated Show resolved Hide resolved
sunxd3 and others added 2 commits February 26, 2024 17:39
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Feb 26, 2024

Pull Request Test Coverage Report for Build 8054133059

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -2 of 28 (92.86%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.293%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/compiler_pass.jl 15 17 88.24%
Totals Coverage Status
Change from base Build 8049063962: 0.1%
Covered Lines: 1479
Relevant Lines: 1842

💛 - Coveralls

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.29%. Comparing base (8471dcf) to head (4797f96).

❗ Current head 4797f96 differs from pull request most recent head a069b49. Consider uploading reports for the commit a069b49 to get more accurate results

Files Patch % Lines
src/compiler_pass.jl 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   80.15%   80.29%   +0.14%     
==========================================
  Files          21       21              
  Lines        1844     1842       -2     
==========================================
+ Hits         1478     1479       +1     
+ Misses        366      363       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunxd3 sunxd3 closed this Feb 26, 2024
@sunxd3 sunxd3 reopened this Feb 26, 2024
@sunxd3 sunxd3 merged commit 8f63957 into master Feb 26, 2024
@sunxd3 sunxd3 deleted the sunxd/cleanup_interface branch February 26, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants