Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logdensity tests #263

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Enable logdensity tests #263

merged 4 commits into from
Dec 12, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Dec 12, 2024

it appears that test group log_density is not run in CI, this PR fixes it

@sunxd3 sunxd3 mentioned this pull request Dec 12, 2024
Copy link
Contributor

Benchmark results on macOS (aarch64)

BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.5.0 to /Users/runner/.bridgestan/bridgestan-2.5.0
Done!
Model dogs produces error: ErrorException("log_density() failed with unknown exception\n")

Model Parameter Count Data Count Stan Density Time (µs) Stan Density Gradient Time (µs) JuliaBUGS Density Time with Graph Walk (µs) JuliaBUGS Density Gradient Time with ReverseDiff.jl(compiled tape) (µs)
rats 65 150 5.5416 8.25 58.083 243.958
pumps 12 10 0.988483 1.52606 8.95833 19.709
dogs 2 720 NA NA 140.75 318.75
seeds 26 21 2.40527 3.1584 21.334 64.5
surgical_realistic 14 12 1.47727 2.00893 11.75 28.959
magnesium 108 96 13.8125 15.292 108.395 205.48
salm 22 18 4.41667 5.16667 16.542 42.041
equiv 15 20 4.1805 5.1875 15.042 46.209
dyes 9 30 2.00638 2.5555 9.6875 40.542
stacks 6 21 1.44079 2.07983 18.167 42.875
epil 303 236 44.834 50.584 194.146 561.291
blockers 47 44 2.83333 3.46517 44.416 88.542
oxford 244 240 12.292 14.4375 262.833 550.333
lsat 1006 5000 110.25 155.917 1341.71 2941.27
bones 33 422 80.459 91.917 336.792 410.125
mice 20 65 7.33333 9.22233 22.208 86.541
kidney 64 58 9.271 12.75 50.833 173.167
leuk 18 714 19.125 25.042 147.708 518.583
leukfr 40 714 25.375 31.834 279.584 691.75

Benchmark results on Ubuntu (x64)

BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.5.0 to /home/runner/.bridgestan/bridgestan-2.5.0
Done!
Model dogs produces error: ErrorException("log_density() failed with exception: Exception: bernoulli_lpmf: Probability parameter is inf, but must be in the interval [0, 1] (in '/home/runner/work/JuliaBUGS.jl/JuliaBUGS.jl/benchmark/stan/bugs_examples/vol1/dogs/dogs.stan', line 37, column 6 to line 38, column 62)\n")

Model Parameter Count Data Count Stan Density Time (µs) Stan Density Gradient Time (µs) JuliaBUGS Density Time with Graph Walk (µs) JuliaBUGS Density Gradient Time with ReverseDiff.jl(compiled tape) (µs)
rats 65 150 5.4662 8.07833 66.794 85.2785
pumps 12 10 1.00221 1.3375 11.717 6.84775
dogs 2 720 NA NA 172.44 149.487
seeds 26 21 2.55927 3.17367 26.76 19.737
surgical_realistic 14 12 1.26282 1.5935 25.542 8.50233
magnesium 108 96 10.5295 12.213 124.831 79.317
salm 22 18 2.3714 3.118 20.719 12.5085
equiv 15 20 2.55564 3.48138 18.865 15.418
dyes 9 30 0.995833 1.337 12.1425 13.084
stacks 6 21 1.13481 1.69135 23.122 15.87
epil 303 236 35.085 40.947 262.847 239.369
blockers 47 44 3.34 3.817 59.3 28.493
oxford 244 240 16.35 18.995 335.222 173.792
lsat 1006 5000 182.499 221.526 2077.41 1213.55
bones 33 422 73.497 91.82 526.041 184.442
mice 20 65 7.574 9.33733 29.956 40.395
kidney 64 58 10.62 16.18 68.627 93.233
leuk 18 714 20.839 27.09 228.78 223.038
leukfr 40 714 23.944 31.959 236.599 242.21

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12305533726

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 72.505%

Totals Coverage Status
Change from base Build 12301989596: 1.1%
Covered Lines: 1424
Relevant Lines: 1964

💛 - Coveralls

@sunxd3 sunxd3 merged commit 1829fd1 into master Dec 12, 2024
15 checks passed
@sunxd3 sunxd3 deleted the sunxd/enable_logp_test branch December 12, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants