Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission to benchmark CI #264

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add permission to benchmark CI #264

merged 1 commit into from
Dec 13, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Dec 13, 2024

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12320456022

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.505%

Totals Coverage Status
Change from base Build 12306133977: 0.0%
Covered Lines: 1424
Relevant Lines: 1964

💛 - Coveralls

@sunxd3
Copy link
Member Author

sunxd3 commented Dec 13, 2024

okay, the segfault is caused by BridgeStan on macOS

@sunxd3
Copy link
Member Author

sunxd3 commented Dec 13, 2024

I am going to merge this now, maybe in some PRs we can disable the MacOS benchmark momentarily

@sunxd3 sunxd3 merged commit 89d03ac into master Dec 13, 2024
14 of 15 checks passed
@sunxd3 sunxd3 deleted the sunxd/benchmark_ci_improve branch December 13, 2024 19:16
@miguelbiron
Copy link
Collaborator

Oh yeah that segfault haunted our dreams for a while. It happens only on the newer Github runners with macOS-14 and ARM arch processors. So in Pigeons we decided to just the older runners (macOS-13).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants