Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularising Bayesian Network (Experimental) #271

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

naseweisssss
Copy link
Collaborator

No description provided.

naseweisssss and others added 5 commits January 25, 2025 16:34
@coveralls
Copy link

coveralls commented Jan 25, 2025

Pull Request Test Coverage Report for Build 13005989660

Details

  • 0 of 113 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 74.278%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/experimental/ProbabilisticGraphicalModels/bayesian_network.jl 0 2 0.0%
src/experimental/ProbabilisticGraphicalModels/conditioning.jl 0 38 0.0%
src/experimental/ProbabilisticGraphicalModels/functions.jl 0 73 0.0%
Totals Coverage Status
Change from base Build 12334000793: 0.9%
Covered Lines: 1441
Relevant Lines: 1940

💛 - Coveralls

@sunxd3
Copy link
Member

sunxd3 commented Jan 26, 2025

Other than fixing the formatting (extra line at the end of the file), looks good

@naseweisssss
Copy link
Collaborator Author

Other than fixing the formatting (extra line at the end of the file), looks good

Removed

Copy link
Contributor

Benchmark results on macOS (aarch64)

BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.6.1 to /Users/runner/.bridgestan/bridgestan-2.6.1
Done!
Model dogs produces error: ErrorException("log_density() failed with unknown exception\n")

Model Parameter Count Data Count Stan Density Time (µs) Stan Density Gradient Time (µs) JuliaBUGS Density Time with Graph Walk (µs) JuliaBUGS Density Gradient Time with ReverseDiff.jl(compiled tape) (µs)
rats 65 150 4.97917 7.05567 80.792 305.583
pumps 12 10 0.856194 1.09225 10.042 22.0
dogs 2 720 NA NA 140.708 305.895
seeds 26 21 1.9 2.316 23.0 61.167
surgical_realistic 14 12 1.185 1.41291 11.396 27.125
magnesium 108 96 9.91667 10.7915 126.542 205.875
salm 22 18 3.33789 3.98214 17.875 42.041
equiv 15 20 3.52986 3.95243 15.5 48.459
dyes 9 30 1.50442 1.6745 10.1045 45.708
stacks 6 21 1.24418 1.61364 18.0 44.75
epil 303 236 32.292 35.334 195.084 637.209
blockers 47 44 2.63636 2.79167 45.708 85.334
oxford 244 240 11.5835 13.6875 262.0 526.75
lsat 1006 5000 98.834 134.334 1344.71 3478.29
bones 33 422 75.042 91.791 333.5 383.375
mice 20 65 6.6665 8.06933 21.625 87.667
kidney 64 58 8.63867 11.646 65.708 175.0
leuk 18 714 16.416 22.041 269.041 494.583
leukfr 40 714 22.709 28.875 275.812 686.167

Benchmark results on Ubuntu (x64)

BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.6.1 to /home/runner/.bridgestan/bridgestan-2.6.1
Done!
Model dogs produces error: ErrorException("log_density() failed with exception: Exception: bernoulli_lpmf: Probability parameter is inf, but must be in the interval [0, 1] (in '/home/runner/work/JuliaBUGS.jl/JuliaBUGS.jl/benchmark/stan/bugs_examples/vol1/dogs/dogs.stan', line 37, column 6 to line 38, column 62)\n")

Model Parameter Count Data Count Stan Density Time (µs) Stan Density Gradient Time (µs) JuliaBUGS Density Time with Graph Walk (µs) JuliaBUGS Density Gradient Time with ReverseDiff.jl(compiled tape) (µs)
rats 65 150 5.2058 7.47067 68.0575 89.888
pumps 12 10 0.944323 1.12404 11.867 6.4445
dogs 2 720 NA NA 168.917 147.727
seeds 26 21 1.93427 2.43208 28.614 24.5705
surgical_realistic 14 12 1.27413 1.44525 15.87 8.53267
magnesium 108 96 10.545 12.1125 142.878 117.279
salm 22 18 2.26192 2.7171 21.761 12.594
equiv 15 20 2.53745 3.31875 19.987 16.28
dyes 9 30 0.981167 1.15215 12.3135 13.0345
stacks 6 21 1.04696 1.39262 23.594 15.89
epil 303 236 27.602 34.094 283.005 352.279
blockers 47 44 3.06911 3.46775 61.0045 34.875
oxford 244 240 13.9265 16.341 361.557 173.915
lsat 1006 5000 164.262 203.491 2004.49 1305.24
bones 33 422 72.886 89.628 427.269 189.925
mice 20 65 7.286 9.22733 28.944 38.161
kidney 64 58 11.041 16.751 68.659 72.566
leuk 18 714 21.931 28.182 249.226 224.35
leukfr 40 714 26.48 33.723 225.782 393.967

@sunxd3 sunxd3 merged commit 9192e48 into master Jan 28, 2025
15 checks passed
@sunxd3 sunxd3 deleted the rylin/bayesnet_modularise branch January 28, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants