Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated read and write #241

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Fix deprecated read and write #241

merged 2 commits into from
Sep 29, 2020

Conversation

devmotion
Copy link
Member

Fixes a bug introducing when deprecating read and write. Instead of overloading Base.read and Base.write we accidentally added new MCMCChains.read and MCMCChains.write methods.

@devmotion devmotion requested a review from cpfiffer September 29, 2020 13:21
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files          20       20           
  Lines        1242     1242           
=======================================
  Hits          901      901           
  Misses        341      341           
Impacted Files Coverage Δ
src/MCMCChains.jl 66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb487bc...ae19c01. Read the comment docs.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @devmotion -- Looks good to me!

@devmotion devmotion merged commit 0208256 into master Sep 29, 2020
@devmotion devmotion deleted the read branch September 29, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants