Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #284

Merged
merged 11 commits into from
Apr 8, 2021
Merged

Fix failing tests #284

merged 11 commits into from
Apr 8, 2021

Conversation

devmotion
Copy link
Member

No description provided.

@devmotion
Copy link
Member Author

It might not be possible to set the displaysize reliably due to JuliaLang/julia#34721...

@devmotion devmotion requested a review from cpfiffer April 8, 2021 11:29
torfjelde
torfjelde reviewed Apr 8, 2021
View reviewed changes
src/stats.jl Show resolved Hide resolved
torfjelde
torfjelde approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no MCMCChains aficionado, but this seems to be a minor change to one particular doctest to deal with the displaysize issue, so I think my "LGTM!" sufficies here?

So.

LGTM!

src/chains.jl Show resolved Hide resolved
@devmotion devmotion merged commit 2d710cb into master Apr 8, 2021
@devmotion devmotion deleted the dw/julia16 branch April 8, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torfjelde torfjelde torfjelde approved these changes

@cpfiffer cpfiffer Awaiting requested review from cpfiffer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmotion @torfjelde