CompatHelper: bump compat for "DataFrames" to "1.0" for package test #294
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cpfiffer
force-pushed
the
compathelper/new_version/2021-04-23-07-18-28-352-2022370914
branch
from
19e3af5 to
e105fd3
Compare
|
I assume the same problem exists here as in the closed PR: PrettyTables 0.12 is installed in the tests (not only in the build phase) but downgraded again once MLJModels etc are pulled in. But let's see, maybe it actually works. |
|
The problem is MLJBase: version 0.18.2 supports only PrettyTables 1 and version 0.18.1 supports only PrettyTables <= 0.11. |
|
I guess it's sufficient that tests pass on Julia 1.0 and Julia 1.6 32bit (including printing of statistics etc.) with PrettyTables 0.12? |
|
What about just dropping PrettyTables 0.12 from the list? It shouldn't matter much now that version 1.0 is out |
|
Both options would be OK. To me it seems sufficiently well tested on Julia 1.0 and 1.6 32bit to be supported but I would also be fine with dropping it. |
|
Good point. I didn't realize that it would happen automatically. I'll go ahead and merge this one and add 0.12 back in #292 |
delete-merged-branch
bot
deleted the
compathelper/new_version/2021-04-23-07-18-28-352-2022370914
branch
This pull request changes the compat entry for the
DataFramespackage from0.22.4to0.22.4, 1.0for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.