Fix for issue #1352 #1357
Merged
Fix for issue #1352 #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point! Nah, that doesn't catch it because it only deals with univariate variables. I'll make it so that it also includes multivariate and matrixvariates 👍 |
|
Done 👍 |
cpfiffer
approved these changes
Jul 17, 2020
|
Classic. We got AD-issues completely unrelated to the changes introduced in this PR again! Bleh. Do we just merge and open an issue related to the AD-stuff? |
|
Seems to be an issue with the interaction between Tracker.jl and PDMats.jl, and unrelated to Turing. EDIT: Made an issue for now: #1358. |
|
I am merging now; let's fix the AD issue in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352, i.e. makes
transitions_from_chainand thuspredictcompatible withMCMCChains@0.4and higher.