Fix and add more AD tests #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamed82008
requested review from
trappmartin,
willtebbutt,
yebai and
xukai92
yebai
approved these changes
Dec 13, 2018
REQUIRE
Outdated
| @@ -11,6 +11,7 @@ MacroTools | |||
| StatsFuns 0.7.0 | |||
| SpecialFunctions | |||
| Bijectors | |||
| FDM | |||
There was a problem hiding this comment.
Move the dependency on FDM to test/REQUIRE?
There was a problem hiding this comment.
Well, that's what I thought I did! Thanks for pointing this out.
|
Thanks, @mohamed82008. This PR looks good to me. Just one minor comment about dependency, see code review. |
trappmartin
requested changes
Dec 13, 2018
| x = map(_->Float64(_), vi[nothing]) | ||
| ∇E = gradient_reverse(x, vi, ad_test_f) | ||
| x = map(x->Float64(x), vi[nothing]) | ||
| ∇E = gradient_reverse(x, vi, ad_test_f)[2] |
There was a problem hiding this comment.
Yes, the first value seems to be negative the logp, whereas the second is the gradient. This is defined here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #624 and adds another workaround for
binomlogpdfandForwardDiff. It also adds tests for these AD functions and fixes other broken AD tests.