Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gaussian mixture tutorial #293

Merged
merged 7 commits into from
Mar 24, 2022
Merged

Update Gaussian mixture tutorial #293

merged 7 commits into from
Mar 24, 2022

Conversation

devmotion
Copy link
Member

This PR

  • reorganizes the Gaussian mixture tutorial a bit,
  • fixes deprecations
  • simplifies code
  • removes internal or unofficial use of MCMCChains

I had updated other tutorials as well but I have to recover them from my broken laptop... While updating I noticed also that

  • Turing 0.21 is roughly 3x slower than Turing 0.18 (350sec vs 110sec on my computer)
  • Turing 0.21, or rather recent Libtask, does not support @inbounds (yields an @error message)

@devmotion @github-actions
Apply suggestions from code review
7d0aefc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@devmotion
Copy link
Member Author

Preview: https://julialang-buildkite-artifacts.s3.amazonaws.com/turingtutorials/abfba9bffabb19ceca3e2a8d3be0056137358b9724cf27ef1bf627b76b8cbca5/html/01-gaussian-mixture-model/01_gaussian-mixture-model.html

There are some typos that I'll fix before merging this PR.

rikhuijzer
rikhuijzer approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@rikhuijzer rikhuijzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff David

tutorials/01-gaussian-mixture-model/01_gaussian-mixture-model.jmd Outdated Show resolved Hide resolved
@devmotion devmotion closed this Mar 23, 2022
@devmotion devmotion reopened this Mar 23, 2022
@devmotion
Copy link
Member Author

The current version is https://julialang-buildkite-artifacts.s3.amazonaws.com/turingtutorials/579bac1e906cc400d63af5ce1539160550de26797a7fed531e19589571cabe84/html/01-gaussian-mixture-model/01_gaussian-mixture-model.html

@devmotion devmotion merged commit ce51cad into master Mar 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the dw/gaussianmixture branch March 24, 2022 07:33
@devmotion devmotion mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rikhuijzer rikhuijzer rikhuijzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmotion @rikhuijzer