Update truncated and MvNormal
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tutorials/10-bayesian-differential-equations/10_bayesian-differential-equations.jmd
Outdated
Show resolved
Hide resolved
tutorials/10-bayesian-differential-equations/10_bayesian-differential-equations.jmd
Outdated
Show resolved
Hide resolved
devmotion
commented
Oct 5, 2022
tutorials/10-bayesian-differential-equations/10_bayesian-differential-equations.jmd
Outdated
Show resolved
Hide resolved
…rential-equations.jmd Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yebai
approved these changes
Oct 10, 2022
| using ReverseDiff | ||
|
|
||
| using LinearAlgebra | ||
| using Random |
There was a problem hiding this comment.
Is there any reason why we are switching styles for imports?
There was a problem hiding this comment.
There's no consistent style currently (and also not when this PR is merged), I mainly felt that the diff is simpler when adding or removing packages if they are on separate lines.
|
|
||
| # Calculate all the mu terms. | ||
| mu = intercept .+ x * coefficients | ||
| return y ~ MvNormal(mu, sqrt(σ₂)) | ||
| return y ~ MvNormal(mu, σ² * I) |
There was a problem hiding this comment.
This is nicer than the old syntax.
|
Thanks, @devmotion - it looks good except for some clarification comments above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates most
MvNormalcalls to the new (not deprecated) syntax andtruncatedtotruncated(...; lower=..., upper=...). The last one is less problematic (e.g. for ForwardDiff) in particular if only one bound is non-finite and hence does not have to be specified; additionally, it avoids possibly undesired promotions.