Fixing benchmarking issues for extensions

TurnerSoftware · Feb 9, 2021 · 936cc00 · 936cc00
1 parent 367e9be
commit 936cc00
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/benchmarks/CacheTower.Benchmarks/Extensions/BaseCacheChangeExtensionBenchmark.cs b/benchmarks/CacheTower.Benchmarks/Extensions/BaseCacheChangeExtensionBenchmark.cs
@@ -9,7 +9,7 @@ public abstract class BaseCacheChangeExtensionBenchmark : BaseExtensionsBenchmar
 		public DateTime BenchmarkValue;
 
 		[GlobalSetup]
-		public void Setup()
+		public virtual void Setup()
 		{
 			BenchmarkValue = DateTime.UtcNow;
 		}

diff --git a/benchmarks/CacheTower.Benchmarks/Extensions/BaseExtensionsBenchmark.cs b/benchmarks/CacheTower.Benchmarks/Extensions/BaseExtensionsBenchmark.cs
@@ -18,7 +18,7 @@ public class ConfigSettings : ManualConfig
 		{
 			public ConfigSettings()
 			{
-				AddJob(Job.Default.WithRuntime(CoreRuntime.Core31).WithMaxIterationCount(200));
+				AddJob(Job.Default.WithRuntime(CoreRuntime.Core50).WithMaxIterationCount(200));
 				AddDiagnoser(MemoryDiagnoser.Default);
 
 				SummaryStyle = new BenchmarkDotNet.Reports.SummaryStyle(CultureInfo, true, SizeUnit.B, TimeUnit.Nanosecond);

diff --git a/benchmarks/CacheTower.Benchmarks/Extensions/Redis/RedisRemoteEvictionExtensionBenchmark.cs b/benchmarks/CacheTower.Benchmarks/Extensions/Redis/RedisRemoteEvictionExtensionBenchmark.cs
@@ -7,8 +7,7 @@ namespace CacheTower.Benchmarks.Extensions.Redis
 {
 	public class RedisRemoteEvictionExtensionBenchmark : BaseCacheChangeExtensionBenchmark
 	{
-		[GlobalSetup]
-		public new void Setup()
+		public override void Setup()
 		{
 			CacheExtensionProvider = () => new RedisRemoteEvictionExtension(RedisHelper.GetConnection(), new ICacheLayer[] { new MemoryCacheLayer() });
 		}