NullReferenceException on blocked task when original task faulted #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e key result, including null
rgueldenpfennig
changed the title
Turnerj
approved these changes
Nov 5, 2021
rgueldenpfennig
deleted the
nullreferenceexception-on-concurrent-access
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the described issue in #192
When a
getterof a cache key is throwing an exception, from now on this exception will be set on the correlating task completion source, instead of setting the result to null.A specific unit test to ensure this behavior was added:
GetOrSet_ConcurrentAccess_OnExceptionFurthermore I added another unit test, that ensures the happy path, either with value and null.
I was not able to execute the whole test suite because I'm missing Redis and Mongo on my current machine. Would be great if someone else could validate the complete test suite. Hope that's okay.