More dependency injection improvements #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These won't be deprecated yet because they are so new but will be hidden by editors that observe the `EditorBrowsable` attribute.
With the idea to move them to the builder pattern, there is no point adding new overloads that are already hidden.
This technically allows a named `ICacheStack<TContext>` to be resolved from an `ICacheStackAccessor` as well as an `ICacheStackAccessor<TContext>`. For an `ICacheStack`, that will throw an exception if tried to be resolved from an `ICacheStackAccessor<TContext>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Changes:
IServiceProviderwhen using the builder patternI don't really like having so many variations of the service collection extensions but without breaking compatibility, this is what is required for now - might make them hidden from the editor to kinda "gracefully" push developers to the ones with the
IServiceProvider, marking the old ones as obsolete in a later version.Additionally would like to investigate a better method of passing
ICacheContextActivatorvia DI - perhaps as part of the builder?