Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213 by disabling default behaviour in Protobuf but more than that, it prevents serialization exceptions from bubbling out. Instead they are caught (and now logged).
The result is, if there are serialization issues when setting the cache on a particular layer, besides the logging, that layer will be skipped and will cause a cache miss on that layer on future requests. When retrieving an item from the cache and that causes a serialization exception, this will just be treated as a cache miss on that layer.
Notes:
NullLogger
. It is using structured logging but only in these error paths - more complete structured logging changes are still to come.