Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify distributed locking extension system #240

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

Turnerj
Copy link
Member

@Turnerj Turnerj commented Apr 9, 2023

Simplifies the distributed locking extension system, dropping the ICacheRefreshCallSiteWrapperExtension interface for a more direct IDistributedLockExtension with then a major overhaul to the RedisLockExtension.

The main benefits of this is that it avoids the responsibility of the cache factory from getting passed into the extension and instead just allows the extension to control the distributed lock behaviour.

It may reduce allocations from closures but more importantly, actually just makes the code easier to work with and the extension system a bit nicer. It being easier to work with allows more opportunity for flexibility around this code including logging, metrics, other traceability and even just other method signatures.

@Turnerj Turnerj added enhancement New feature or request minor labels Apr 9, 2023
@Turnerj Turnerj merged commit b27251d into main Apr 10, 2023
@Turnerj Turnerj deleted the simplify-distributed-locking branch April 10, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant