Simplify distributed locking extension system #240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the distributed locking extension system, dropping the
ICacheRefreshCallSiteWrapperExtension
interface for a more directIDistributedLockExtension
with then a major overhaul to theRedisLockExtension
.The main benefits of this is that it avoids the responsibility of the cache factory from getting passed into the extension and instead just allows the extension to control the distributed lock behaviour.
It may reduce allocations from closures but more importantly, actually just makes the code easier to work with and the extension system a bit nicer. It being easier to work with allows more opportunity for flexibility around this code including logging, metrics, other traceability and even just other method signatures.