Unit test to confirm PingSession.cs statistics (#15)

* Started on two unit test methods for PingSession

* Refactor, cleanup comments. Add assert for TestPingStatisticsDivideByZero()

* merge in dividebyzero fix

* add asserts to main stats test and resolve some decimal rounding issues

* add in the divide by zero fix for AverageRoundTrip

* Apply code style changes already done elsewhere.

* Use var and remove System. #15 (comment)

src/Pingalot.Core/PingSession.cs

@@ -61,6 +61,8 @@ private void CalculateStatistics()
 			{
 				PacketsLost = PacketsSent - PacketsReceived;
 				PacketsLostPercentage = (double)PacketsLost / PacketsSent * 100;
+				PacketsLostPercentage = Math.Round(PacketsLostPercentage, 2);
+
 
 				if (PacketsReceived > 0)
 				{

tests/Pingalot.Core.Tests/PingSessionTests.cs

@@ -17,10 +17,10 @@ public void TestPingStatisticsDivideByZero()
 			var pingRequests = new List<PingRequest>();
 
 			var startTime = new DateTime(2022, 5, 19, 14, 30, 0);
-			var duration = TimeSpan.FromSeconds(30);
+			var duration = new TimeSpan(0, 0, 0, 30);
 			var endTime = startTime.Add(duration);
 
-
+			// Setup a single failed ping(TimedOut)
 			var pingRequest = new PingRequest
 			{
 				Address = IPAddress.Loopback,
@@ -36,7 +36,84 @@ public void TestPingStatisticsDivideByZero()
 
 			var testPingSession = new PingSession(startTime, endTime, duration, pingRequests);
 
+			// When we have a single failed ping request - our AverageRoundtrip should be 0
 			Assert.AreEqual(testPingSession.AverageRoundtrip, 0, "If PacketsReceived is 0, when we attempt to calculate AverageRoundTrip we may trigger a divide by zero exception.");
 		}
+
+		[TestMethod]
+		public void ConfirmPingSessionStatistics()
+		{
+			// Mock up PingRequests with specific values
+			// Manually calculate the expected statistics 
+			// Assert stats are correct
+
+			var pingRequests = new List<PingRequest>();
+
+			var startTime = new DateTime(2022, 5, 19, 14, 30, 0);
+			var duration = new TimeSpan(0, 0, 0, 30);
+			var endTime = startTime.Add(duration);
+
+			// Create 6 successful pings 10ms RT
+			for (int i = 0; i < 6; i++)
+			{
+				var pingRequest = new PingRequest
+				{
+					Address = IPAddress.Loopback,
+					Status = IPStatus.Success,
+					RoundtripTime = 10,
+					TimeToLive = 58,
+					BufferLength = 32,
+					HasMatchingBuffer = true,
+					RequestTime = DateTime.Now
+				};
+
+				pingRequests.Add(pingRequest);
+			}
+
+			// Create 2 successful pings 5ms RT 
+			for (int i = 0; i < 3; i++)
+			{
+				var pingRequest = new PingRequest
+				{
+					Address = IPAddress.Loopback,
+					Status = IPStatus.Success,
+					RoundtripTime = 5,
+					TimeToLive = 58,
+					BufferLength = 32,
+					HasMatchingBuffer = true,
+					RequestTime = DateTime.Now
+				};
+
+				pingRequests.Add(pingRequest);
+			}
+
+			// Create 2 TimedOut pings
+			for (int i = 0; i < 2; i++)
+			{
+				var pingRequest = new PingRequest
+				{
+					Address = IPAddress.Loopback,
+					Status = IPStatus.TimedOut,
+					RoundtripTime = 0,
+					TimeToLive = 0,
+					BufferLength = 0,
+					HasMatchingBuffer = false,
+					RequestTime = DateTime.Now
+				};
+
+				pingRequests.Add(pingRequest);
+			}
+
+			var testPingSession = new PingSession(startTime, endTime, duration, pingRequests);
+
+			// assert that stats add up properly - calc them manually and not via debug
+			Assert.AreEqual(testPingSession.PacketsReceived, 9, "PacketsReceived should be 9.");
+			Assert.AreEqual(testPingSession.PacketsSent, 11, "PacketsSent should be 11.");
+			Assert.AreEqual(testPingSession.PacketsLost, 2, "PacketsLost should be 2.");
+			Assert.AreEqual(testPingSession.PacketsLostPercentage, 18.18, "PacketsLostPercentage should be 18.18%");
+			Assert.AreEqual(testPingSession.MinimumRoundtrip, 5, "MinimumRoundtrip should be 5");
+			Assert.AreEqual(testPingSession.MaximumRoundtrip, 10, "MinimumRoundtrip should be 10");
+			Assert.AreEqual(testPingSession.AverageRoundtrip, 8.33, "AverageRoundtrip should equal 75 divided by 9 = 8.33 rounded to two decimal places.");
+		}
 	}
 }