Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing FPE when an item is not initialised. #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing FPE when an item is not initialised. #388

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

No description provided.

@devnexen
Copy link
Contributor Author

devnexen commented Aug 16, 2018 •
edited
Loading

Spotted first with 3.1.4 version but thought it was due to missing data but then occurred again (but randomly and rarely) with 3.2.0 as well, basically 216 items while possibly 218.

Do not know if the approach would be to not load the game or this solution or making sure all data is present.

@WALLOFJUSTICE
Copy link
Collaborator

To clarify, 3.2.0 increased the number of items by 1, as well as adding a new entry to items.txt. Likely crash is on a line like (appearance % items[type].variations) where variations is uninitialised and could be 0.

Solution can also be just to properly initialise some item properties to non-0

@devnexen
Copy link
Contributor Author

devnexen commented Aug 18, 2018 •
edited
Loading

Yes exactly a fpe is division by zero.

@devnexen
Copy link
Contributor Author

Tried your suggestion, realising building under Mac is ... tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @WALLOFJUSTICE