Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a CI build for Windows #603

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Added a CI build for Windows #603

wants to merge 2 commits into from

Conversation

addictgamer
Copy link
Collaborator

@addictgamer addictgamer commented Dec 9, 2021

Our build config files are terrible and potato king should feel ashamed of himself.

I want to do a little bit more cleanup before we merge this. I probably botched some random stuff to get this working.

(Reopening #602 from a branch under this repo since forks don't have access to secrets)

Tasks:

  • Cleanup pass
  • Set a specific Windows version
  • Test the exe files in Windows
  • ??
  • Pizza party I guess

@addictgamer
Copy link
Collaborator Author

> file barony.exe
barony.exe: PE32+ executable (GUI) x86-64, for MS Windows

Woot! Looks like it is 64 bit.
Will need to boot into Windows sometime to actually test it.

@@ -33,6 +33,7 @@ find_path(SDL2_TTF_INCLUDE_DIR SDL_ttf.h
HINTS
ENV SDLTTFDIR
ENV SDLDIR
${SDL2DIR}
Copy link
Collaborator Author

@addictgamer addictgamer Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Oof, indentation mismatch that wasn't visible in my editor. :|

@addictgamer addictgamer marked this pull request as draft December 9, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant