Skr/more stuff #664
Merged
Skr/more stuff #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… screen height < 720p
| info.locked = false; // TODO | ||
| info.flags = 0; // TODO | ||
| info.ping = 50; // TODO | ||
| info.locked = false; // this will always be false because steam only reported joinable lobbies |
There was a problem hiding this comment.
Need to add lobby attribute for game in session, EOS uses CURRENTLEVEL and then if currentlevel >= 0 report LobbyHandler_t::EResult_LobbyFailures::LOBBY_GAME_IN_PROGRESS Host needs to continually update this lobby attribute as per EOS, EOSFuncs::LobbyData_t::updateLobbyDuringGameLoop()
Need to add 'visibility' attribute as well, PERMISSIONLEVEL to show full lobbies
There was a problem hiding this comment.
Lobbies are closed when the game starts, otherwise yeah i would do that. We should probably go with the "every lobby is MAXPLAYERS + 1 in size" method
F6 to screenshot always works w/ gamepads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.