Fixes Issues building with steamworks enabled by linking nfd and GTK3. #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issues building with steamworks enabled by linking nfd and GTK3.
|
We use this script to create builds in production so I'm very hesitant to merge in anything that can break that. |
|
As long as it's working for you, there's not really any reason to change it. Frankly I can't get a Windows version to build no matter what I do, cross-compiling or booting into my windows disk |
Signed-off-by: Frosted <iceball457@gmail.com>
Merge updates from master branch into children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all chunks except the last: The environment variables weren't getting populated correctly so I skipped the command line variables check. This prevents the paths from being set on the command line, but allows them to be correctly read from the environment variables.
For the last chunk: Linked glib2, nfd, and gtk3