Make BARONY_SUPER_MULTIPLAYER functional #824
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the precompiler directive
BARONY_SUPER_MULTIPLAYER
and makes it functional (though still buggy). I do not have Steamworks or EOS so this has only been tested both with multiple local instances and LAN mode with port forwarding over internet.Fixes:
NET_PACKET_SIZE
being larger than the packet data used to load an existing 8 player save. Thechunk_size
inlobbyPlayerJoinRequest()
is 98 bytes, and the packet length is defined as8 + MAXPLAYERS * chunk_size
, resulting in a total of 792 bytes. The oldNET_PACKET_SIZE
is 512, which is too small. I'm not sure what's a good number so I just doubled it.USE_PLAYFAB
off since I didn't have the libraries/includes, so I moved the includes underneath it.Bugs: