User data dir #85
Closed
User data dir #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5cb8063.
cppfuncs.hpp:getLinesFromFile → files.cpp:getLinesFromDataFile Also rewrite most of its implementation to provide useful errors when the file cannot be opened.
- Add the openUserFile function, analogous to openDataFile, which opens files containing user data, i.e. config, saves and scores. - Make the default location for user files $XDG_CONFIG_HOME/barony or $HOME/.config/barony if those variables are found. This should probably be replaced with behaviour more suitable for OSX ($HOME/Library/Application Support/barony?) and windows (%APPDATA%/barony?) - Add -userdir= option which allows overriding the aforementioned behaviour - Add setUserDir and setDataDir to the files module, so the knowledge of the static storage for these paths can be limited to files.cpp. Correspondingly, - Remove public datadir variable
This was referenced Jun 13, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed to some extent in #79 as well.
The key functionality-introducing commit here is ef15650. Pasting its description here for ease of reading:
Move all direct user directory access to files.cpp
files containing user data, i.e. config, saves and scores.
$HOME/.config/barony if those variables are found. This should
probably be replaced with behaviour more suitable for OSX
($HOME/Library/Application Support/barony?) and windows
(%APPDATA%/barony?)
behaviour
the static storage for these paths can be limited to files.cpp.
Correspondingly,
In addition, this: