-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
141/fix response system #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just have a quick question!
app/models/mention.rb
Outdated
@@ -8,18 +8,19 @@ def self.retrieve_mentions | |||
twitter = Twitter_API.new | |||
@client = twitter.client | |||
mentions = @client.mentions_timeline | |||
@account_name = @client.user.screen_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be an instance variable? It seems to only be used here and within the each block, so I think a normal variable without the @
would make more sense
Additional question: Can we write any more tests to ensure that the issue is fully resolved and stays that way? |
…nd_mentions test helper method
Hey @vkoves, could you please help me get unstuck on the test I'm trying to write? There was a test helper method meant to generate a tweet with |
@McEileen - it took a good bit of digging, but I think I got the issue resolved. The |
@vkoves Thanks for all of the digging! The Now I'm having a hard time figuring out how to test that the bot sends a tweet which includes the potential educatee's handle with an |
@McEileen - that is a great question, but unfortunately I've been unable to figure out how to do that. Especially since the I found this article that should be helpful for this, but I couldn't get it to work; perhaps you can figure it out though? |
That article looks helpful, thank you! I want to deploy the fixes, so I am going to merge in the changes |
That seems fine. Since this is such a small change and unlikely to break again, I think manually testing it and then taking the testing on later should be sufficient. |
Hi @vkoves, could you please review these changes? In response to issue #141, I added an @ before the educatee's handle and fixed the code so Tweechable won't tweet at itself. Thanks!
fixes #141