142/fix thread link new lesson #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable, but it's generally cleaner to just take the params for creation rather than setting each variable individually. Take a look at how the contacts controller handles creation, as I think that's a little bit nicer and would prevent this type of error from cropping up again. As for testing, I don't think this change needs it per se, but we should probably have tests around lesson creation that should have caught this. That seems outside of the scope of this PR though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vkoves, could you please review these changes? It fixes both #142 and #140 because when I was trying to figure out the thread link problem, I realized both issues stem from an issue on the controller page's
createmethod. This also made me realize we need to use strong params throughout the application - @kthong3 is on the case.Are you going to say this change needs testing? If so, I will add tests. 🙏
fixes #142
fixes #140