Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logs for kubelet non-ready nodes #18

Merged
merged 5 commits into from
Apr 15, 2022

Conversation

ryanjkemper
Copy link
Contributor

This PR resolves two issues I've seen while using this application:

First, on some larger clusters we would see:

ASG has X non-ready updated nodes/instances, waiting until all nodes/instances are ready  

However, this would run in a loop with no indication of which instances were not ready even though according to kubectl, it seemed that all instances were ready. Adding another log line to report which instances were not ready helps aid in troubleshooting nodes that are not ready for long periods of time.


Second, it adds git to the Dockerfile else, docker builds fail for me with the following error:

Step 4/9 : RUN CGO_ENABLED=0 GOOS=linux go build -mod vendor -a -installsuffix cgo -o aws-eks-asg-rolling-update-handler .
 ---> Running in 79e131118b89
go: missing Git command. See https://golang.org/s/gogetcmd
error obtaining VCS status: exec: "git": executable file not found in $PATH
        Use -buildvcs=false to disable VCS stamping.
The command '/bin/sh -c CGO_ENABLED=0 GOOS=linux go build -mod vendor -a -installsuffix cgo -o aws-eks-asg-rolling-update-handler .' returned a non-zero code: 1

main.go Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ryanjkemper
Copy link
Contributor Author

I've made your suggested updates and tested that the Dockerfile still builds. I can test the node rolling status we were issuing within the next week or two as I run it against our clusters again.

@ryanjkemper ryanjkemper requested a review from TwiN April 7, 2022 16:42
@TwiN TwiN changed the title Add logs for kubelet non-ready nodes, Add git to Dockerfile Add logs for kubelet non-ready nodes and fix Dockerfile Apr 9, 2022
TwiN
TwiN previously approved these changes Apr 9, 2022
main.go Show resolved Hide resolved
@TwiN TwiN dismissed their stale review April 9, 2022 19:51

Failing check

@ryanjkemper ryanjkemper requested a review from TwiN April 12, 2022 20:04
@TwiN TwiN changed the title Add logs for kubelet non-ready nodes and fix Dockerfile feat: Add logs for kubelet non-ready nodes Apr 15, 2022
@TwiN TwiN merged commit 1a7056b into TwiN:master Apr 15, 2022
@ryanjkemper
Copy link
Contributor Author

@TwiN Thanks for the merge!

Is there a schedule when a new release/docker hub image will be cut? Looks like latest may be updated, but generally don't like using latest tag

@TwiN
Copy link
Owner

TwiN commented May 5, 2022

Thank you for the contribution!

I've just released v1.3.0 for you, sorry for the delay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants