-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add logs for kubelet non-ready nodes #18
Conversation
I've made your suggested updates and tested that the Dockerfile still builds. I can test the node rolling status we were issuing within the next week or two as I run it against our clusters again. |
@TwiN Thanks for the merge! Is there a schedule when a new release/docker hub image will be cut? Looks like |
Thank you for the contribution! I've just released v1.3.0 for you, sorry for the delay :) |
This PR resolves two issues I've seen while using this application:
First, on some larger clusters we would see:
However, this would run in a loop with no indication of which instances were not ready even though according to kubectl, it seemed that all instances were ready. Adding another log line to report which instances were not ready helps aid in troubleshooting nodes that are not ready for long periods of time.
Second, it adds git to the Dockerfile else, docker builds fail for me with the following error: