Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Add support for PTR DNS records #886

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

d7415
Copy link
Contributor

@d7415 d7415 commented Nov 2, 2024

Summary

This just adds PTR to the supported DNS record types.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (52a7312) to head (454736f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   77.49%   77.50%   +0.01%     
==========================================
  Files          72       72              
  Lines        5802     5806       +4     
==========================================
+ Hits         4496     4500       +4     
  Misses       1089     1089              
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TwiN TwiN added the feature New feature or request label Nov 28, 2024
@TwiN TwiN merged commit 29cbff6 into TwiN:master Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants