fix(tls): add test for insecure flag #942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds tests to complement work done in TwiN#547 it was rumored that tls insecure was not working, although tls insecure appears to be working fine, no test was found originally. this adds a test to ensure that tls insecure works as expected. the domain badssl.com is used to verify that the insecure flag works as expected
TwiN
approved these changes
Dec 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #942 +/- ##
==========================================
+ Coverage 75.75% 75.81% +0.06%
==========================================
Files 72 72
Lines 6649 6649
==========================================
+ Hits 5037 5041 +4
+ Misses 1308 1305 -3
+ Partials 304 303 -1 ☔ View full report in Codecov by Sentry. |
|
@pnikonowicz I had no idea badssl.com was a thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds tests to complement work done in
#547
it was rumored that tls insecure was not working,
although tls insecure appears to be working fine,
no test was found originally.
this adds a test to ensure that tls insecure works as expected. the domain badssl.com is used to
verify that the insecure flag works as expected
Summary
address issue #932
Checklist
README.md, if applicable.