feat: refactor main logic into cmd package and add cobra cli support #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the Cobra CLI, including the -v command to print the version(#901) and the -t command to test configurations(#960).
I think we might also need to modify CI-related or Docker image-related files (I didn't make changes to the CI code since I'm not very familiar with it), because the version used by -v needs to be passed during the build process:
go build -ldflags="-X github.com/TwiN/gatus/v5/cmd.version=1.0.1" .I haven't added any test files, but I have conducted tests on my macOS, and no issues were found during the testing.
Checklist
README.md, if applicable.