Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analy and assist in list of default false positives #35

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

tbantle22
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #35 (49d410e) into master (8998110) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files           1        1           
  Lines         191      191           
=======================================
  Hits          190      190           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8998110...49d410e. Read the comment docs.

@TwiN TwiN changed the title Add more false positives Add analy and assist in list of default false positives Jun 23, 2022
@@ -2,12 +2,14 @@ package goaway

// DefaultFalsePositives is a list of words that may wrongly trigger the DefaultProfanities
var DefaultFalsePositives = []string{
"analy", // analysis, analytics
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this one could probably be abused (even if the proper way to type it would be anally), but we'd have to add analyz for analyze, analyt for analytics and analys for analysis, so I guess we'll just go with analy as you've suggested.

Ultimately, users are free to provide their own list of false positives, so it shouldn't be too much of a big deal.

@TwiN TwiN merged commit b8d99f2 into TwiN:master Jun 23, 2022
@TwiN
Copy link
Owner

TwiN commented Jun 23, 2022

Thank you for the contribution!

Released in v1.6.6.

@TwiN TwiN added bug Something isn't working enhancement New feature or request labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants