fix: data race in remove accents #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 191 167 -24
=========================================
- Hits 191 167 -24 ☔ View full report in Codecov by Sentry. |
TwiN
changed the title
|
@rafax Thank you for the contribution! |
rafax
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Feb 16, 2024
rafax
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Feb 16, 2024
* rg/preconfigure_detecotr * Chat only * Comment * Add TwiN/go-away#80 * Bazel
rafax
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Feb 20, 2024
* rg/preconfigure_detecotr * Chat only * Comment * Add TwiN/go-away#80 * Bazel * Update go.sum * Remove * Use a set * remove testing overrides * Log pattern * bazel * Latency + comments * Comment * Reorder seen * Comment * Switch set implementation * Bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a data race associated with reuse of
removeAccentsTransformer- when IsProfane() or other methods are called from multiple goroutines (ex. in a HTTP Server handler), sanitization fails withslice bounds out of rangeerrors.The issue is fixed by using a new instance of
removeAccentsTransformerfor every call toremoveAccents.To reproduce, run the newly added
BenchmarkIsProfaneConcurrently_WithAccentswith(note - it will pass on the last commit of this branch that contains a fix).
Summary
Fix a data race in
removeAccents, makingProfanityDetectorsafe for use from multiple goroutines.Checklist
README.md, if applicable.