Change module name to Tyk org #164

buger · 2021-10-01T17:54:16Z

Unfortunately using replace directive is not possible because of this issue golang/go#30354
Replace directives can be used only for local development and can't be inherited by repos which use module fork.
Also see https://www.reddit.com/r/golang/comments/j8pqms/go_modules_making_me_rage_how_do_i_fork_a_module/

At the moment we have put "replace" directive, with the specific commit of this lib to EVERY project which depends on this lib, even Tyk Dashboard. Additionally, even users who write Go plugins have to add this replaces statement too, which creates terrible developer experience.

At the moment, re-naming all imports and module itself in fork is the only option to solve the issue.

alephnull · 2021-10-04T07:20:36Z

I think this is the best way of approaching this issue from the standpoint of DX. These changes would enable our open-source offering to be a better free software citizen.
I agree with Leo that there no other option than a hard fork in technical terms. I am also aware that this is a not just a code problem and impacts ownership. I feel it would be good to have these discussions sooner rather than later.

buger · 2021-10-04T11:07:40Z

One of the downsides of such approach that it can cause quite a lot of merge conflicts. Hard to pull changes from the original upstream and etc. Plus at the moment it is literally just search and replace from text editor, e.g. manual job.

What I want to do is to create a special "tyk" branch, which will be automatically creating Tyk based module version out of master, and our future internal releases will be based on top of it. E.g. it will call some replace commands, maybe internal refactoring tooling https://pkg.go.dev/golang.org/x/tools/refactor/rename, go mod commands and etc. Such hybrid approach should have benefits for bot developers of this module and end-users.