Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-9916] Add current semantic convention attributes to spans for GQL #33

Conversation

buraksezer
Copy link
Contributor

@buraksezer buraksezer commented Oct 23, 2023

This PR adds the following attributes for GraphQL/UDG:

  • operation.name -> func GraphQLOperationName(name string) trace.Attribute
  • operation.type -> func GraphQLOperationType(operationType string) trace.Attribute
  • document -> func GraphQLDocument(document string) trace.Attribute

See TT-9916 for details.

@buraksezer buraksezer requested a review from pvormste October 23, 2023 09:15
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@buraksezer buraksezer merged commit 97112d7 into main Oct 23, 2023
3 of 4 checks passed
@kofoworola kofoworola deleted the feat/TT-9916/Add-current-semantic-convention-attributes-to-spans-for-GQL-in-the-GW branch October 23, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants