Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

feat: upgrade crds and webhooks to v1 #124

Closed
asoorm opened this issue Oct 25, 2020 · 3 comments
Closed

feat: upgrade crds and webhooks to v1 #124

asoorm opened this issue Oct 25, 2020 · 3 comments
Assignees
Labels
blocked enhancement New feature or request

Comments

@asoorm
Copy link
Member

asoorm commented Oct 25, 2020

After deploying the operator using make deploy IMG=tykio/tyk-operator:latest, then applying an API definition:

kubectl apply -f ./config/samples/httpbin.yaml

Error from server (InternalError): error when creating "./config/samples/httpbin.yaml": Internal error occurred: failed calling webhook "mapidefinition.kb.io": expected response.uid="c27dafd5-51e9-4b21-b773-9da861d0a14e", got ""

Operator logs:

2020-10-25T17:48:51.371Z        ERROR   controller-runtime.webhook.webhooks     unable to decode the request    {"webhook": "/mutate-tyk-tyk-io-v1alpha1-apidefinition", "error": "no kind \"AdmissionReview\" is registered for version \"admission.k8s.io/v1\" in scheme \"pkg/runtime/scheme.go:101\""}
github.com/go-logr/zapr.(*zapLogger).Error
        /go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).ServeHTTP
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/webhook/admission/http.go:79
sigs.k8s.io/controller-runtime/pkg/webhook.instrumentedHook.func1
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/webhook/server.go:129
net/http.HandlerFunc.ServeHTTP
        /usr/local/go/src/net/http/server.go:2036
net/http.(*ServeMux).ServeHTTP
        /usr/local/go/src/net/http/server.go:2416
net/http.serverHandler.ServeHTTP
        /usr/local/go/src/net/http/server.go:2831
net/http.(*conn).serve
        /usr/local/go/src/net/http/server.go:1919
2020-10-25T17:48:51.372Z        DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/mutate-tyk-tyk-io-v1alpha1-apidefinition", "UID": "", "allowed": false, "result": {}, "resultError": "got runtime.Object without object metadata: &Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:,Message:no kind \"AdmissionReview\" is registered for version \"admission.k8s.io/v1\" in scheme \"pkg/runtime/scheme.go:101\",Reason:,Details:nil,Code:400,}"}
@asoorm
Copy link
Member Author

asoorm commented Oct 29, 2020

Cannot use CRD v1 or Webhooks v1. We will stick with v1beta1 till the underlying tooling catches up and we can work our way round breaking changes between apis.

operator-framework/operator-sdk#3580
https://v1-16.docs.kubernetes.io/docs/setup/release/notes/
kubernetes-sigs/controller-runtime#1161
kubernetes-sigs/controller-runtime#1123

@asoorm asoorm pinned this issue Oct 29, 2020
@asoorm asoorm added the enhancement New feature or request label Oct 29, 2020
@asoorm asoorm changed the title bug: no kind "AdmissionReview" is registered for version feat: upgrade crds and webhooks to v1 Oct 29, 2020
@asoorm asoorm added blocked and removed bug labels Oct 29, 2020
@asoorm asoorm added this to the v0.5.0 milestone Dec 24, 2020
@asoorm asoorm removed the blocked label Dec 24, 2020
@asoorm
Copy link
Member Author

asoorm commented Dec 24, 2020

Dependent on #220

@asoorm asoorm unpinned this issue Dec 24, 2020
@gernest gernest removed this from the v0.5.0 milestone Jan 14, 2021
@asoorm
Copy link
Member Author

asoorm commented May 27, 2021

Closed by #316

@asoorm asoorm closed this as completed May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants